misc: dynamic linking code refactor#141
Merged
ldm0 merged 1 commit intoCCExtractor:masterfrom Aug 16, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the dynamic linking code in the build script by creating a new FFmpegLinkMode enum to replace the inline string matching, improving type safety and code organization.
- Introduced a proper enum
FFmpegLinkModewithFrom<String>andDisplayimplementations - Simplified the linking functions to use the enum's
Displaytrait directly in cargo link commands - Extracted common single library linking logic into a new
linking_with_single_libfunction
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.